Skip to content

fix behavior does not match flake8-import-order >= 0.19.0 behavior #226

@bkeryan

Description

@bkeryan

ni/measurement-plugin-python#1173 (comment)

I can't seem to fix the lint error in the sample_measurement. It says it need a newline above the TYPE_CHECKING but it already has one and I've tried adding newlines in and around there and 'poetry run ni-python-styleguid fix' doesn't do it.

ni/nidaqmx-python#761 (comment)

I pushed a commit fixing the lint failure. The conditional TYPE_CHECKING block made the linter upset, and I couldn't find a clean way to make it happy, so I noqa it.

#225 blocks installation of flake8-import-order 0.19.0 due to a regression with older Python versions, but it sounds like we will also need to update the fix behavior when 0.19.1 or 0.20.0 is released

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions