Skip to content

Commit e530d32

Browse files
Allow registration of unnamespaced elements in element manager. For now.
1 parent bd60415 commit e530d32

File tree

3 files changed

+21
-6
lines changed

3 files changed

+21
-6
lines changed

ng-appserver/src/main/java/ng/appserver/NGApplication.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import ng.appserver.resources.StandardResourceType;
3232
import ng.appserver.routing.NGRouteTable;
3333
import ng.appserver.templating.NGElementManager;
34-
import ng.appserver.templating.NGElementUtils;
3534
import ng.appserver.wointegration.NGDefaultLifeBeatThread;
3635
import ng.appserver.wointegration.WOMPRequestHandler;
3736
import ng.plugins.NGPlugin;
@@ -160,10 +159,10 @@ public static <E extends NGApplication> E runAndReturn( final String[] args, fin
160159
application.loadPlugins();
161160

162161
// The application class' package gets added by default // FIXME: Don't like this Hugi 2022-10-10
163-
NGElementUtils.addPackage( applicationClass.getPackageName() );
162+
application._elementManager.registerElementPackage( applicationClass.getPackageName() );
164163

165164
// FIXME: Registering for the instance stopper to work. Horrid stuff. We need to convert NGAdminAction to routes // Hugi 2025-03-16
166-
NGElementUtils.addClass( NGAdminAction.class );
165+
application._elementManager.registerElementClass( NGAdminAction.class );
167166

168167
// FIXME: Eventually the adaptor startup should probably be done by the user
169168
application.createAdaptor().start( application );

ng-appserver/src/main/java/ng/appserver/templating/NGElementManager.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,26 @@ private static <E extends NGDynamicElement> E createDynamicElementInstance( fina
149149
*/
150150
private final Map<String, String> _elementTagNames = new HashMap<>();
151151

152+
/**
153+
* FIXME: Allows us to invoke registerElementClass without a namespace. Temporary while we're working on namespaces
154+
*/
155+
@Deprecated
156+
public void registerElementClass( final Class<?> elementClass, String... tagNames ) {
157+
registerElementClass( GLOBAL_UNNAMESPACED_NAMESPACE, elementClass, tagNames );
158+
}
159+
160+
/**
161+
* FIXME: Allows us to invoke registerElementPackage without a namespace. Temporary while we're working on namespaces
162+
*/
163+
@Deprecated
164+
public void registerElementPackage( final String packageName ) {
165+
registerElementPackage( GLOBAL_UNNAMESPACED_NAMESPACE, packageName );
166+
}
167+
152168
/**
153169
* Registers an element class for use in the application
154170
*/
155-
public void registerElementClass( final String namespace, final Class<? extends NGElement> elementClass, String... tagNames ) {
171+
public void registerElementClass( final String namespace, final Class<?> elementClass, String... tagNames ) {
156172
_elementClasses.add( elementClass );
157173

158174
for( String shortcut : tagNames ) {

ng-appserver/src/main/java/ng/appserver/templating/NGElementUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ public class NGElementUtils {
6363
*/
6464
@Deprecated
6565
public static void addClass( final Class<?> elementClass, final String... tagNames ) {
66-
NGApplication.application().elementManager().registerElementClass( NGElementManager.GLOBAL_UNNAMESPACED_NAMESPACE, (Class<? extends NGElement>)elementClass, tagNames );
66+
NGApplication.application().elementManager().registerElementClass( (Class<? extends NGElement>)elementClass, tagNames );
6767
}
6868

6969
@Deprecated
7070
public static void addPackage( final String packageName ) {
71-
NGApplication.application().elementManager().registerElementPackage( NGElementManager.GLOBAL_UNNAMESPACED_NAMESPACE, packageName );
71+
NGApplication.application().elementManager().registerElementPackage( packageName );
7272
}
7373
}

0 commit comments

Comments
 (0)