-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(settings): conditionally display developer documentation link based on configuration #56794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
212bc41 to
48e6ba0
Compare
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pr 🙏
48e6ba0 to
e69b649
Compare
e69b649 to
9c46001
Compare
9c46001 to
370c02e
Compare
|
Hi @Arsalanulhaq, We would prefer to drop the link from the apps store rather than adding a configuration option for it. |
Hi @kesselb |
370c02e to
51ae765
Compare
c662141 to
c4eae96
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
c4eae96 to
272f936
Compare
272f936 to
0b639ad
Compare
0b639ad to
9ec4e4e
Compare
|
@kesselb as discussed. I have removed the developer documentation link from code now. |
9ec4e4e to
349e015
Compare
349e015 to
bf1be05
Compare
|
Thank you @Arsalanulhaq 🙏 |
Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
…sed on configuration Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
bf1be05 to
46858ef
Compare
Summary
Adds a new application configuration
display_documentation_linkthat allows hiding the developer documentation link in the app settings page.Changes
AppSettingsController::viewApps()to conditionally setappstoreDeveloperDocsbased on thedisplay_documentation_linkconfigurationConfiguration
settings→display_documentation_linktrue(documentation link is shown)"true"or"false"(as string)Usage
Hide the documentation link:
occ config:app:set settings display_documentation_link --value="false"Show the documentation link (default):
occ config:app:set settings display_documentation_link --value="true"Checklist
3. to review, feature component)stable32)