From 418ea7d9eebf8bcb5e3b7a5fbfadebfa7907a9cd Mon Sep 17 00:00:00 2001
From: Kostiantyn Miakshyn <molodchick@gmail.com>
Date: Fri, 21 Nov 2025 01:38:15 +0100
Subject: [PATCH] feat: shows a confirmation dialog on question deletion

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
---
 src/components/Questions/Question.vue |  2 +-
 src/views/Create.vue                  | 55 ++++++++++++++++++++++++++-
 2 files changed, 55 insertions(+), 2 deletions(-)

diff --git a/src/components/Questions/Question.vue b/src/components/Questions/Question.vue
index eed065b20..bf663687e 100644
--- a/src/components/Questions/Question.vue
+++ b/src/components/Questions/Question.vue
@@ -114,7 +114,7 @@
 						</template>
 						{{ t('forms', 'Copy question') }}
 					</NcActionButton>
-					<NcActionButton @click="onDelete">
+					<NcActionButton close-after-click @click="onDelete">
 						<template #icon>
 							<IconDelete :size="20" />
 						</template>
diff --git a/src/views/Create.vue b/src/views/Create.vue
index de3827b54..ac47f431b 100644
--- a/src/views/Create.vue
+++ b/src/views/Create.vue
@@ -139,7 +139,7 @@
 							:max-string-lengths="maxStringLengths"
 							v-bind.sync="form.questions[index]"
 							@clone="cloneQuestion(question)"
-							@delete="deleteQuestion(question.id)"
+							@delete="questionToDelete = question"
 							@move-down="onMoveDown(index)"
 							@move-up="onMoveUp(index)" />
 					</transition-group>
@@ -172,10 +172,23 @@
 				</div>
 			</section>
 		</template>
+
+		<!-- Confirmation dialog for deleting question -->
+		<NcDialog
+			:open.sync="showConfirmDeleteDialog"
+			:name="t('forms', 'Delete question')"
+			:message="
+				t('forms', 'Are you sure you want to delete question {text}?', {
+					text: questionToDelete ? questionToDelete.text : '',
+				})
+			"
+			:buttons="confirmDeleteButtons" />
 	</NcAppContent>
 </template>
 
 <script>
+import IconCancelSvg from '@mdi/svg/svg/cancel.svg?raw'
+import IconDeleteSvg from '@mdi/svg/svg/delete.svg?raw'
 import axios from '@nextcloud/axios'
 import { showError } from '@nextcloud/dialogs'
 import { emit } from '@nextcloud/event-bus'
@@ -187,6 +200,8 @@ import Draggable from 'vuedraggable'
 import NcActionButton from '@nextcloud/vue/components/NcActionButton'
 import NcActions from '@nextcloud/vue/components/NcActions'
 import NcAppContent from '@nextcloud/vue/components/NcAppContent'
+import NcButton from '@nextcloud/vue/components/NcButton'
+import NcDialog from '@nextcloud/vue/components/NcDialog'
 import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
 import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
 import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
@@ -213,9 +228,13 @@ export default {
 		Draggable,
 		IconLock,
 		IconPlus,
+		IconCancelSvg,
+		IconDeleteSvg,
 		NcActionButton,
 		NcActions,
 		NcAppContent,
+		NcButton,
+		NcDialog,
 		NcEmptyContent,
 		NcLoadingIcon,
 		NcNoteCard,
@@ -238,6 +257,28 @@ export default {
 
 			maxStringLengths: loadState('forms', 'maxStringLengths'),
 			questionMenuOpened: false,
+
+			questionToDelete: null,
+
+			confirmDeleteButtons: [
+				{
+					label: t('forms', 'Cancel'),
+					icon: IconCancelSvg,
+					type: 'tertiary',
+					callback: () => {
+						this.questionToDelete = null
+					},
+				},
+				{
+					label: t('forms', 'Delete question'),
+					icon: IconDeleteSvg,
+					type: 'error',
+					callback: () => {
+						this.deleteQuestion(this.questionToDelete.id)
+						this.questionToDelete = null
+					},
+				},
+			],
 		}
 	},
 
@@ -306,6 +347,18 @@ export default {
 		lockedUntilFormatted() {
 			return moment(this.form.lockedUntil, 'X').fromNow()
 		},
+
+		showConfirmDeleteDialog: {
+			get() {
+				return this.questionToDelete !== null
+			},
+
+			set(value) {
+				if (!value) {
+					this.questionToDelete = null
+				}
+			},
+		},
 	},
 
 	watch: {