delete resources in shared calendar is broken

[tatrapikao]

Steps to reproduce

1. add a resource to an existing event in a calendar shared with you
2. update event
3. wait for availability check > its not gonna happen add resource to event in shared calendar is confusing (and broken?) #179
   2.try to delete resource from event.

Expected behavior

resource is removed from event and available again.

Actual behavior

i get an error.
resource persists

App version

0.9.0

Additional info

hacky way to get rid of the resource:

1. navigate to resources tab of the event in question
2. remove resource -> dont click update
3. instead duplicate event -> save
4. reload page
5. delete the event that still has the resource attatched
6. keep the event without resource
7. sadly the resource is now blocked forever for the period of the deleted event...(as it seems to me)

[st3iny]

Thanks for the report.

I can reproduce the problem. This is similar to another error we are trying to debug for some time. Saving the event will cause "Failed to save event" error toast to be shown.

I an also reproduce that the status of the room is never updated. It will stay on pending.

Response

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Error</s:exception>
  <s:message>__clone method called on non-object</s:message>
</d:error>

Exception

{
  "Exception": "Error",
  "Message": "__clone method called on non-object",
  "Code": 0,
  "Trace": [
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/vobject/lib/ITip/Broker.php",
      "line": 244,
      "function": "parseEventForOrganizer",
      "class": "OCA\\DAV\\CalDAV\\TipBroker",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php",
      "line": 616,
      "function": "parseEvent",
      "class": "Sabre\\VObject\\ITip\\Broker",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/apps/dav/lib/CalDAV/Schedule/Plugin.php",
      "line": 199,
      "function": "processICalendarChange",
      "class": "Sabre\\CalDAV\\Schedule\\Plugin",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
      "line": 89,
      "function": "calendarObjectChange",
      "class": "OCA\\DAV\\CalDAV\\Schedule\\Plugin",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/dav/lib/CalDAV/Plugin.php",
      "line": 889,
      "function": "emit",
      "class": "Sabre\\DAV\\Server",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/dav/lib/CalDAV/Plugin.php",
      "line": 733,
      "function": "validateICalendar",
      "class": "Sabre\\CalDAV\\Plugin",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
      "line": 89,
      "function": "beforeWriteContent",
      "class": "Sabre\\CalDAV\\Plugin",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/dav/lib/DAV/Server.php",
      "line": 1133,
      "function": "emit",
      "class": "Sabre\\DAV\\Server",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
      "line": 492,
      "function": "updateFile",
      "class": "Sabre\\DAV\\Server",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
      "line": 89,
      "function": "httpPut",
      "class": "Sabre\\DAV\\CorePlugin",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/3rdparty/sabre/dav/lib/DAV/Server.php",
      "line": 472,
      "function": "emit",
      "class": "Sabre\\DAV\\Server",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/apps/dav/lib/Connector/Sabre/Server.php",
      "line": 49,
      "function": "invokeMethod",
      "class": "Sabre\\DAV\\Server",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/apps/dav/lib/Server.php",
      "line": 408,
      "function": "start",
      "class": "OCA\\DAV\\Connector\\Sabre\\Server",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/apps/dav/appinfo/v2/remote.php",
      "line": 22,
      "function": "exec",
      "class": "OCA\\DAV\\Server",
      "type": "->"
    },
    {
      "file": "/home/richard/src/nextcloud/master/remote.php",
      "line": 151,
      "args": [
        "/home/richard/src/nextcloud/master/apps/dav/appinfo/v2/remote.php"
      ],
      "function": "require_once"
    }
  ],
  "File": "/home/richard/src/nextcloud/master/apps/dav/lib/CalDAV/TipBroker.php",
  "Line": 104,
  "message": "__clone method called on non-object",
  "exception": {},
  "CustomMessage": "__clone method called on non-object"
}

cc @SebastianKrupinski Could you please have a look?