SequenceComposer reuses the same ID across the Hopscotch web UI

[zardoz03]

Hello,

I was looking into how the Workspace UI gets created and noticed that IDs for the UI elements aren't unique across the webpage.
A query on the Workspace UI reveals 21 elements with the same ID.

newspeak/HopscotchForHTML5.ns

Lines 3346 to 3348 in 296ff25

	container
	at: 'id' put: 'SequenceComposer';
	at: 'contentEditable' put: 'false'.

I found the offending code above. Ideally this would be a class instead of an ID, but I do not know how SequenceComposers get used by the rest of the IDE, so I am hesitant to send a PR/patch since I don't know the codebase.
Also something else I noticed is that subclasses of SequenceComposer don't alter their HTML elements to stamp their own identity on it, and often lack createVisual.

[gbracha]

Thanks for looking into this. Generally, the ids are only there to help with debugging and do not provide any critical function. Of course, you're right that it would be nice to have them be unique. As for subclasses not having createVisual - that is intentional. If they don't create a different HTML structure, there is no need for them to override createVisual. Even if we were to give them different ids, I'd mak ethat into a separate method that would be called by createVisual. The sad reality is that there are so many more pressing needs - bugs and features - that this ha snver been a priority.