Possible memory leak and not thread safe singleton

[gestern]

It looks like a simultaneously a non thread-safe singleton and aligning it with the paradigm PImpl.

avalon/avalon/platform/ios/payment/payment.mm

Lines 305 to 310 in 52ff1f0

	static IOSManager *manager = nullptr;
	if(!manager)
	{
	manager = new IOSManager();
	}
	return manager;

[newnon]

most part of cocos2d-x not thread safe. avalon also does not thread safe
every function must be called inside lock or something similar even "getInstance()"

[gestern]

most part of cocos2d-x not thread safe. avalon also does not thread safe
every function must be called inside lock or something similar even "getInstance()"

Yes, I agree, but in the cocos2d-x they are executed all the same in one of three main isolated threads: either a render or I/O or networks and they are still synchronized with each other. In any case, there is a memory leak even if we do not take into consideration the race in the initialization of the singleton.