assign default value for status_symbol

Author: qrkourier

netfoundry/organization.py

@@ -581,14 +581,10 @@ def find_network_groups_by_organization(self, **kwargs):
         """
         url = self.audience+'rest/v1/network-groups'
         headers = {"authorization": "Bearer " + self.token}
-        try:
-            network_groups = list()
-            for i in find_generic_resources(url=url, headers=headers, embedded=RESOURCES['network-groups']._embedded, proxies=self.proxies, verify=self.verify, **kwargs):
-                network_groups.extend(i)
-        except Exception as e:
-            raise RuntimeError(f"failed to get network_groups from url: '{url}', caught {e}")
-        else:
-            return(network_groups)
+        network_groups = list()
+        for i in find_generic_resources(url=url, headers=headers, embedded=RESOURCES['network-groups']._embedded, proxies=self.proxies, verify=self.verify, **kwargs):
+            network_groups.extend(i)
+        return(network_groups)
     get_network_groups_by_organization = find_network_groups_by_organization
     network_groups = get_network_groups_by_organization
 

netfoundry/utility.py

@@ -360,6 +360,7 @@ def find_generic_resources(url: str, headers: dict, embedded: str = None, proxie
             logging.warn("ignoring invalid value for header 'accept': '{:s}'".format(accept))
 
     try:
+        status_symbol = "UNKNOWN"
         response = http.get(
             url,
             headers=headers,
@@ -370,10 +371,7 @@ def find_generic_resources(url: str, headers: dict, embedded: str = None, proxie
         status_symbol = STATUS_CODES._codes[response.status_code][0].upper()
         response.raise_for_status()
     except RequestException as e:
-        logging.error('unexpected HTTP response code {:s} ({:d}) and response {:s}'.format(
-                status_symbol,
-                response.status_code,
-                response.text))
+        logging.error(f"unexpected HTTP response code {status_symbol} ({response.status_code}) and response {response.text}")
         raise e
     else:
         try: