fix: correct StorageClass schema and add missing core resources #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StorageClass was incorrectly mapped to spec/status fields, but it actually has top-level fields: provisioner, parameters, reclaimPolicy, volumeBindingMode, allowVolumeExpansion, mountOptions. Also adds 9 missing core K8s resources that were not registered: - StorageClass (schema fix only - was registered but wrong) - PriorityClass: value, preemptionPolicy, description, globalDefault - RuntimeClass: handler, overhead, scheduling - IngressClass: spec - CSIDriver: spec - CSINode: spec - VolumeAttachment: spec, status - EndpointSlice: addressType, endpoints, ports - ControllerRevision: revision, data - Lease: spec (was in schema but not registered)
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spec/statusfields, but K8s StorageClass actually has top-level fields:provisioner,parameters,reclaimPolicy,volumeBindingMode,allowVolumeExpansion,mountOptionsResources Added
value,preemption_policy,description,global_defaulthandler,overhead,schedulingspecspecspecspec,statusaddress_type,endpoints,portsrevision,dataspec(was in schema but not registered)Test plan
cargo build --releasecompiles successfullycargo test- all 314 tests passcargo clippy- no warningsSELECT * FROM storageclassesnow returns actual data (provisioner, parameters, etc.)SELECT * FROM priorityclasses,runtimeclasses,endpointslices, etc.