Skip to content
This repository was archived by the owner on Nov 12, 2017. It is now read-only.
This repository was archived by the owner on Nov 12, 2017. It is now read-only.

Add user:email permission #95

@ndahlquist

Description

@ndahlquist

Currently, when someone presses the merge button, we use that user's public email address, if available, and fallback to their private @noreply.github.com email if not. (https://github.com/ndahlquist/whaler/blob/dev/appengine/MergeEndpoint.py#L101)

Ideally, we would always use the user's canonical email address. This could be accomplished by using the user:email application permission (see https://developer.github.com/v3/oauth/#scopes).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions