Port `handler` and Command `cmdHandler` pass arguments using different types

[LeStarch]

Here is an example of an autocode port handler:

      //! Handler for input port pythonInPort
      virtual void pythonInPort_handler(
          FwIndexType portNum, //!< The port number
          const FprimePythonReference::PythonEnumeration& arg1,
          const FprimePythonReference::PythonComplexStruct& arg2
      ) = 0;

Now look at the cmdHandler:

      //! Handler for command TYPES_COMMAND
      //!
      //! Enumeration and struct command test
      virtual void TYPES_COMMAND_cmdHandler(
          FwOpcodeType opCode, //!< The opcode
          U32 cmdSeq, //!< The command sequence number
          FprimePythonReference::PythonEnumeration enum_argument,
          FprimePythonReference::PythonComplexStruct struct_argument
      ) = 0;

The same types are passed in one case by const & an by value in the other. This is a confusing and inefficient inconsistency.

[bocchino]

Agreed. I believe this discrepancy exists because the FPP C++ back end was designed to match the old XML autocoders, and the autocoders were designed to support commands with primitive types only in their arguments.