Skip to content

[Bug]: Add mgrs as an optional dependency #35

@nemo794

Description

@nemo794

Checked for duplicates

Yes - I've already checked

Describe the bug

As noted here in PR #32 , the function get_geographic_boundaries_from_mgrs_tile() imports mgrs internally, but there is no option to install mgrs during the installation process, which would lead to a runtime error if a user tries calling this function.

What did you expect?

This function in the codebase is a public function, and so after installation via setup.py, I would expect all functions to be able to run without dependency issues.

However, because this function is not called within the primary DSWx-HLS code, it is not necessary to include mgrs as a required dependency.

One option for handling this is to add mgrs as an optional dependency (link), and then this function and installation process documented in the README.

Here's an example of a README with optional dependencies (link).

Reproducible steps

No response

Environment

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds triageIssue requires triage to proceed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions