Some questions about joy5

[tuan3w]

Hi @nareix ,
Thanks for working on new project. I used joy4 before. And now, it's cool to try joy5 now.

However, I have some questions about joy5:

• About project design: I think rtmp.Conn struct prepresents a object to handle rtmp messages. So it's better if I can access net.Conn object as in joy4 library instead of separate two parameters as in HandleConn method. And in joy5, why Close method in rtmp.Conn is missing ? Developer should send message to client to close connection nicely instead of closing socket connect.
• Do you have any benchmark results between joy5 and joy4?

[ivanjaros]

I will add another question - looking at the code, it looks like there is no support to extract the video out of the flv itself. The connection just decodes the rtmp protocol and makes the flv packets available for reading but it seems there is no way to get the aac audio and mp4 or ts video out of this, like in joy4. Is that correct or am i missing something?

[ivanjaros]

i used external mp4 muxer and it works just fine. but i truly do not like the fact that there are no streams available like in joy4. now the aac and h264 codecs are present in each packet and you have to check if they are set because it depends on the type of packet. i prefer the joy4 approach to this. also i fail to see why i need to handle net.Conn in the handler. i should just provide the rtmp.Conn handler, like in joy4. also now the pps and sps are maps with unknown keys so you have to use for loop, i am not liking this either.

edit: i got it wrong. the mp4 is not working because there are no codec information in any packets. h264 and aac are always nil.