From 574613e04a1f350add78f17993d814a7c0607fc2 Mon Sep 17 00:00:00 2001 From: Topper Bowers Date: Mon, 6 Feb 2012 17:44:23 -0500 Subject: [PATCH 1/5] change binding functions to be on the prototype so that they can be overriden --- backbone.modelbinding.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/backbone.modelbinding.js b/backbone.modelbinding.js index db1f68c..bec99b6 100644 --- a/backbone.modelbinding.js +++ b/backbone.modelbinding.js @@ -98,15 +98,15 @@ var modelbinding = (function(Backbone, _, $) { } } - this.getBindingAttr = function(type){ - return this.bindingAttrConfig[type]; - }; + }; - this.getBindingValue = function(element, type){ - var bindingAttr = this.getBindingAttr(type); - return element.attr(bindingAttr); - }; + modelBinding.Configuration.prototype.getBindingAttr = function(type){ + return this.bindingAttrConfig[type]; + }; + modelBinding.Configuration.prototype.getBindingValue = function(element, type){ + var bindingAttr = this.getBindingAttr(type); + return element.attr(bindingAttr); }; modelBinding.Configuration.bindindAttrConfig = { From 3abedd6d39f38c156ab1fe8920df814b96c11678 Mon Sep 17 00:00:00 2001 From: Topper Bowers Date: Mon, 23 Apr 2012 18:53:32 -0400 Subject: [PATCH 2/5] only update on value --- backbone.modelbinding.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/backbone.modelbinding.js b/backbone.modelbinding.js index bec99b6..1f04f50 100644 --- a/backbone.modelbinding.js +++ b/backbone.modelbinding.js @@ -424,10 +424,14 @@ var modelbinding = (function(Backbone, _, $) { val = modelBinding.Configuration.getDataBindSubst(attr, val); switch(attr){ case "html": - element.html(val); + if (val) { + element.html(val); + } break; case "text": - element.text(val); + if (val) { + element.text(val); + } break; case "enabled": element.attr("disabled", !val); From 306630287d6d0f522c7f2fd5db8dd23f0fabab70 Mon Sep 17 00:00:00 2001 From: Topper Bowers Date: Tue, 24 Apr 2012 19:14:11 -0400 Subject: [PATCH 3/5] better null fixes --- backbone.modelbinding.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backbone.modelbinding.js b/backbone.modelbinding.js index 1f04f50..695a620 100644 --- a/backbone.modelbinding.js +++ b/backbone.modelbinding.js @@ -424,12 +424,12 @@ var modelbinding = (function(Backbone, _, $) { val = modelBinding.Configuration.getDataBindSubst(attr, val); switch(attr){ case "html": - if (val) { + if (val && (typeof val !== 'undefined') && (val !== null)) { element.html(val); } break; case "text": - if (val) { + if (val && typeof val !== 'undefined' && val !== null) { element.text(val); } break; From f4910f7d93515272fcb6c17065074152d487d531 Mon Sep 17 00:00:00 2001 From: Topper Bowers Date: Wed, 25 Apr 2012 14:00:04 -0400 Subject: [PATCH 4/5] oops val --- backbone.modelbinding.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backbone.modelbinding.js b/backbone.modelbinding.js index 695a620..b68a15b 100644 --- a/backbone.modelbinding.js +++ b/backbone.modelbinding.js @@ -424,12 +424,12 @@ var modelbinding = (function(Backbone, _, $) { val = modelBinding.Configuration.getDataBindSubst(attr, val); switch(attr){ case "html": - if (val && (typeof val !== 'undefined') && (val !== null)) { + if ((typeof val !== 'undefined') && (val !== null)) { element.html(val); } break; case "text": - if (val && typeof val !== 'undefined' && val !== null) { + if ((typeof val !== 'undefined') && (val !== null)) { element.text(val); } break; From 399b71fecc10ffe92265ac94bcfe68528be80816 Mon Sep 17 00:00:00 2001 From: bartes Date: Thu, 2 Apr 2015 17:46:35 +0200 Subject: [PATCH 5/5] removed rvmrc --- .rvmrc | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .rvmrc diff --git a/.rvmrc b/.rvmrc deleted file mode 100644 index a11d225..0000000 --- a/.rvmrc +++ /dev/null @@ -1,5 +0,0 @@ -if [[ -n "$rvm_path/environments" && -s "$rvm_path/environments/ruby-1.9.2-p180@bb.mb" ]] ; then - \. "$rvm_path/environments/ruby-1.9.2-p180@bb.mb" -else - rvm --create "ruby-1.9.2-p180@bb.mb" -fi