should set Password improperly disconnect once already set it correctly?

[liocle]

If setting password twice (that includes by mistake ;) the server disconnects the session:

c3r1p3 :: ~ % nc -c localhost 6667 1 ↵ PASS horse USER lio PASS toto ERROR :Password incorrect c3r1p3 :: ~ % nc -c localhost 6667

[liocle]

Is it correct behavior?
PASS correct
USER asdf
PASS again_Incorrect

[mxafi]

Currently disconnecting is somewhat valid maybe, we can check later the proper behavior by hosting ngircd server or something...

[mxafi]

Changing the behavior to match ngircd would require some refactoring:

• Most commands are silent before the client being authenticated
• The password is checked to be correct only after NICK and USER have been supplied (in any order)
• Giving PASS first is not a requirement, only that after NICK and USER have been supplied, it is checked if it was supplied and if it was correct.

So NICK, USER, PASS would have to be just input functions. NICK and USER have to check if the other has already been given, if so, then run some utility getAuthenticated function.
This utility function would check if nick, user, pass have all been given and the password is correct, if not, return some error. Otherwise, the function would send back the numeric auth replies 1-4