Skip to content

MMRecordMarshaler: mergeDuplicateRecordResponseObjectDictionary #106

@ParmeshwarBayappu

Description

@ParmeshwarBayappu

This is based on my understanding. I believe the purpose of this method is to merge the two dictionaries representing the same entity.
Potential Issues:

  1. While iterating over the primaryKeyPaths
    id dictionaryValue = [dictionary valueForKeyPath:keyPath];
    id protoRecordValue = [dictionary valueForKeyPath:keyPath]; //probably meant protoRecord.dictionary.

  2. The check for dictionariesContainIdenticalPrimaryKeys is probably unnecessary as the caller is expected to call this only in that case.

Enhancement Suggestion:

  1. I would suggest truly merging the two dictionaries (copy from dictionary to protoRecord.dictionary). Though I would generally expect this to have been the default behavior, since it should rarely be needed and you documented it very well, this could suggestion can be ignored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions