From ca963c2f525823c705b652a0f2ac035ccdb8f941 Mon Sep 17 00:00:00 2001 From: Igor Date: Tue, 24 Mar 2026 15:18:11 +0200 Subject: [PATCH] fixed EditMidiMappingModel destruction --- .../shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.cpp | 6 +++++- .../shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.cpp b/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.cpp index a5a66e341cc73..b279d14018123 100644 --- a/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.cpp +++ b/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.cpp @@ -34,7 +34,9 @@ EditMidiMappingModel::EditMidiMappingModel(QObject* parent) EditMidiMappingModel::~EditMidiMappingModel() { - midiRemote()->setIsSettingMode(false); + if (m_loaded) { + midiRemote()->setIsSettingMode(false); + } } void EditMidiMappingModel::load(int originType, int originValue) @@ -50,6 +52,8 @@ void EditMidiMappingModel::load(int originType, int originValue) m_event = RemoteEvent(static_cast(originType), originValue); emit mappingTitleChanged(mappingTitle()); + + m_loaded = true; } QString EditMidiMappingModel::mappingTitle() const diff --git a/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.h b/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.h index df22ce3ac085a..66b7cc0ae9bb8 100644 --- a/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.h +++ b/src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.h @@ -57,6 +57,7 @@ class EditMidiMappingModel : public QObject, public Contextable, public async::A private: QString deviceName(const muse::midi::MidiDeviceID& deviceId) const; + bool m_loaded = false; RemoteEvent m_event; }; }