-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Hi munkyboy,
nice work! Thanks for sharing the image with us.
Just a minor suggestion from my side: I suggest that you change
docker run --net=host -e http_proxy=http://1.2.3.4:3128 redsocks
by
docker run --net=host -e http_proxy=http://1.2.3.4:3128 munkyboy/redsocks
(therwise the image will not be found.
Another change request on my side would be to exchange it by
docker run --net=host -e http_proxy=http://yourproxy.company.com:8080 -e https_proxy=http://yourproxy.company.com:8080 munkyboy/redsocks
or if you like it shorter:
docker run --net=host -e http_proxy=http://yourproxy.company.com:8080 munkyboy/redsocks
this would explain better, how the variable is used.
I found port 3128 a little bit confusing, since it looks so much alike the port 3129 used in https://github.com/jpetazzo/squid-in-a-can, which seems to be the local squid port they are using there, while in your docker run command, you need to specify the IP address or name plus port of the external http proxy.
Best Regards,
Oliver
gronico
Metadata
Metadata
Assignees
Labels
No labels