Skip to content

Need to change image name from redsocks to munkyboy/redsocks in docker run command #4

@oveits

Description

@oveits

Hi munkyboy,
nice work! Thanks for sharing the image with us.

Just a minor suggestion from my side: I suggest that you change

docker run --net=host -e http_proxy=http://1.2.3.4:3128 redsocks

by

docker run --net=host -e http_proxy=http://1.2.3.4:3128 munkyboy/redsocks

(therwise the image will not be found.

Another change request on my side would be to exchange it by

docker run --net=host -e http_proxy=http://yourproxy.company.com:8080 -e https_proxy=http://yourproxy.company.com:8080 munkyboy/redsocks

or if you like it shorter:

docker run --net=host -e http_proxy=http://yourproxy.company.com:8080 munkyboy/redsocks

this would explain better, how the variable is used.

I found port 3128 a little bit confusing, since it looks so much alike the port 3129 used in https://github.com/jpetazzo/squid-in-a-can, which seems to be the local squid port they are using there, while in your docker run command, you need to specify the IP address or name plus port of the external http proxy.

Best Regards,
Oliver

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions