feat(code-review): improve get_file_contents tool

[bambam955]

Description

There are many times where the LLM provides inaccurate comments because of its limited view of the project it's reviewing.

For example, in one Qt/C++ MR, a new piece of code used an inline function defined in another file. The bot repeatedly said that this was invalid because it didn't know where the function was defined and had no way of finding out.

The bot already has a get_file_contents tool, but it doesn't always use it effectively...

Proposal

• Allow bot to request a specific line range of a file to avoid getting too much context

[bambam955]

@Pertempto what do you think of this? Have you ever noticed this pitfall in your projects?

[Pertempto]

This tool already exists. get_file_contents

[Pertempto]

https://github.com/mrs-electronics-inc/bots/blob/main/code-review-bot/tools.py#L55

[bambam955]

Nuts, I hadn't seen that. I looked in tools.py but missed it somehow.

Looking back at some job logs, I guess it does use it occasionally...but I wish it would use it more often 😅

[bambam955]

You can close this one if you want. Sorry, didn't realize it was a duplicate.

[Pertempto]

Looking back at some job logs, I guess it does use it occasionally...

Yeah. I have seen this error for .mdx files: #68

but I wish it would use it more often 😅

Maybe we need to update the system prompt to nudge it that way.

It also might be nice to allow the bot to request specific line range of a file. To avoid getting too much context.

That is what the opencode agent does.

[Pertempto]

You can close this one if you want. Sorry, didn't realize it was a duplicate.

Nah, I think there are still useful things to do here. I updated the title. The description still needs updated.

[bambam955]

Description is updated partially 👍