Bug: slice assignment on multidimensional array produces out of bounds error when index within bounds

[tjad]

Affects all versions.
Code to reproduce

require 'mxnet'

a = MXNet::NDArray.ones([5,5])
a[0, 0..4] = MXNet::NDArray.array([1,2,3,4,5])

Output:
git/mxnet.rb/lib/mxnet/ndarray.rb:232:in block in []=' IndexError (slicing stop 5 exceeds limit of 5)

[tjad]

This is only when using the full range of a column or row.

If doing a subslice assignment that does not include full row/column, the slice assignment works as expected.

[tjad]

@mrkn For this issue is only an incomplete feature. there was intent to incorporate exclude_end. this defaults to false currently and is not dynamic (still to be done).

mxnet.rb/ext/mxnet/utils.c

Line 78 in edc85f6

int exclude_end;

Could we default this to true, or is the code reliant on this defaulting to false? - realise tests would need to change.

[tjad]

Ah, perhaps it's this, should be strictly >

mxnet.rb/lib/mxnet/ndarray.rb

Line 231 in edc85f6

elsif stop >= len