Yamlls: Property metrics is not allowed.

[Rom888]

cat hpa.yaml

apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: dd
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: dd
  minReplicas: 2
  maxReplicas: {{ .Values.autoscaling.maxReplicas }}
  metrics:
    - type: External

I see this wrong diagnostics with the code above:

1. Yamlls: Property metrics is not allowed. yaml-schema: https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.32.1-standalone-strict/_definitions.json [513]

But there are no errors without {{ }}:

apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: dd
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: dd
  minReplicas: 2
  maxReplicas: 3
  metrics:
    - type: External

ubuntu, nvim
helm-ls v0.4.1
helm-ls.nvim
filetype=helm
nvim lsp config:

vim.lsp.config('helm_ls', {
  cmd = { 'helm_ls', 'serve' },
  filetypes = { 'helm', 'yaml.helm-values' },
  root_markers = { 'Chart.yaml' },
  capabilities = {
    workspace = {
      didChangeWatchedFiles = {
        dynamicRegistration = true,
      },
    },
  },
})
vim.lsp.enable('helm_ls')

The values.lint.yaml doesn't change anything.

[qvalentin]

This is caused by the way how yamlls integration in helm-ls works and a specific rule in the schema for he hpa.

Helm-ls converts the yaml to the following:

apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: dd
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: dd
  minReplicas: 2
  maxReplicas: 
  metrics:
    - type: External

Which is equivalent to

  maxReplicas: null

The schema for the hpa seems to have a rule that metrics can only be given if maxReplicas is a valid integer which it is not.

There are 2 possible fixes:

1. Have helm-ls correctly template the values (this will be quite complex and can only work if the resulting template is smaller or equal in size as the template string)
2. Add a configuration option for ignoring certain yamlls diagnostic messages (like feat(lint): allow ignoring helm lint messages #146)

[Rom888]

Can helm-ls set all values from values.lint.yaml before sending the result to yamlls?