Incorrect title/alt values for multi-word study names

[pdehaan]

You just need to hover over the experiment names in the eolMessageFour block:

<a data-l10n-name="colorLink" title={-exp-color}>{-exp-color}</a>,

I believe the problem is that we don't have any quotes around the title= bit, so instead of title="Firefox Color", we're ending up with title="Firefox". OK, I don't know why that last part is true. I don't even see the strings in view-source, and both Firefox and Chrome devtools give the same title="Firefox" where I was expecting <a ... title=Firefox Color> where the "Color" would just be some orphaned data arg.

Anyways... not sure it's worth fixing. Yeah, sucks for a11y, but we'd have to change for every locale. But then, that should be pretty easy for somebody to quickly do locally and push to Git outside of updating 20+ locales in Pontoon manually.

testpilot/locales/en-US/app.ftl

Lines 299 to 305 in 9c663ab

	eolMessageFour =
	Other experiments like
	<a data-l10n-name="colorLink" title={-exp-color}>{-exp-color}</a>,
	<a data-l10n-name="sideViewLink" title={-exp-side-view}>{-exp-side-view}</a>,
	<a data-l10n-name="notesLink" title={-exp-notes}>{ -exp-notes}</a>,
	<a data-l10n-name="priceWiseLink" title={-exp-price-wise}>{-exp-price-wise}</a>, and
	<a data-l10n-name="emailTabsLink" title={-exp-email-tabs}>{-exp-email-tabs}</a>

/cc @flodolo for his $0.03.

[flodolo]

There's a pending request to update other locales (potentially enable more, I haven't checked), in particular Dutch (nl).

We could include a fix for this, assuming adding the quotes solves the problem. Where you able to test it locally?

Side question: when is the server shutting down?

[pdehaan]

I ran my really crappy ftl-htmllint tool against the eol branch, but the HTML validation library didn't seemingly catch the orphaned </a> tag in the nl translation, but did catch about 120 of "[E005] attr-quote-style" errors (because of the missing title= quotes), as well as the following errors in cy and fa. But I don't think these strings are in the eol site, and probably no longer used/relevant:

$ npx pdehaan/ftl-htmllint './locales/*/app.ftl'

# Invalid `<a>...</>` markup.
./locales/cy/app.ftl
  - [E042] tag-close: "newsletterFormPrivacyNotice = Rwy'n hapus i Mozilla'n trin fy manylion fel sy'n cael ei amlinellu yn yr <a>hysbysiad preifatrwydd</>hwn."

# Invalid `<a>...<a/>` markups.
./locales/fa/app.ftl
  - [E042] tag-close: "warningMissingPrefDetail = وقتی خلبان آزمایشی را محلی یا در محیطهای توسعه اجرا میکنید، پیکربندی ویژهای مورد نیاز است. برای جزییات لطفا <a>مستندات ما<a/> را ببینید."
  - [E042] tag-close: "warningMissingPrefDetail = وقتی خلبان آزمایشی را محلی یا در محیطهای توسعه اجرا میکنید، پیکربندی ویژهای مورد نیاز است. برای جزییات لطفا <a>مستندات ما<a/> را ببینید."

[pdehaan]

We could include a fix for this, assuming adding the quotes solves the problem. Where you able to test it locally?

I didn't verify it locally, but I finally remembered why this seemed familiar; I fixed this earlier in #4030. Although it looks like my changes got overwritten by a later commit.
Not sure if I should have been submitting against the l10n branch instead of the eol branch.

[flodolo]

They should be submitted against l10n, not eol.

I wonder if the Persian one is an actual error, or just RTL messing up

[pdehaan]

I wonder if the Persian one is an actual error, or just RTL messing up

Not sure, but I'm fairly certain(tm) that those are strings for the old site and I can't verify on the EOL site.

---

Side question: when is the server shutting down?

@meandavejustice @lmorchard @johngruen Do we have any plans to update the Test Pilot EOL site with the latest translations and updates? Or are we planning on killing the server and not doing any other deploys?