AWS/ECR still building and pushing/pulling after the move to GAR

[janbrasna]

With the deployments at GCP and the move to GAR workflow #523/files there's still nonetheless the original CI/CD running:

mozmoderator/.github/workflows/cd.yaml

Lines 62 to 75 in dab64ad

	uses: aws-actions/amazon-ecr-login@v2
	- name: Build and Push Stage Image to ECR
	id: build-push
	if: github.ref == 'refs/heads/main'
	env:
	ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
	ECR_REPOSITORY: moderator
	IMAGE_TAG: ${{ needs.prepare.outputs.FULL_IMAGE_TAG }}
	run: |
	docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
	docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:$GITHUB_SHA
	docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG

with some other legacy factors now contributing to having the container builds run ~4 times in different contexts, and most of that seems redundant.

Is the AWS/ECR path still taken, and useful for any reason? (The images are still pushed there, but question is whether the registry serves any purpose now, or just wastes storage & bandwidth…)

(I'd look into trimming down the workflows a bit to conserve resources and make the actual deployment flow more apparent after cleaning up. Also being able to remove the registry credentials from repo secrets if not used can't hurt.)