Removed time.sleep

Author: Temidayo32

foxpuppet/windows/browser/panel_ui/panel_ui.py

@@ -4,7 +4,7 @@
 """Contains classes for handling Firefox Panel UI (Hamburger menu)."""
 
 from selenium.webdriver.common.by import By
-
+import time
 from foxpuppet.windows.browser.navbar import NavBar
 from selenium.webdriver.remote.webelement import WebElement
 from typing import Type, Any, TYPE_CHECKING, Optional
@@ -95,6 +95,11 @@ def open_new_window(self) -> None:
             )
             new_window = (set(self.selenium.window_handles) - initial_handles).pop()
             self.selenium.switch_to.window(new_window)
+            self.wait.until(
+                lambda _: self.selenium.execute_script("return document.readyState")
+                == "complete",
+                message="New window document not fully loaded",
+            )
 
     def open_private_window(self) -> None:
         """
@@ -170,8 +175,9 @@ def clear_history(self):
                     const clearRecentHistoryButton = shadowRoot.querySelector('button[dlgtype="accept"]');
                     clearRecentHistoryButton.click();
                 """,
-                    self.selenium.find_element(*PanelUILocators.HISTORY_DIALOG_BUTTON),
-                )
+                self.selenium.find_element(*PanelUILocators.HISTORY_DIALOG_BUTTON),
+            )
+        time.sleep(1)
 
 
 class PanelUILocators:

tests/test_panel_ui.py

@@ -4,8 +4,10 @@
 """Tests for Panel UI."""
 
 import pytest
-import time
 from selenium.webdriver.remote.webdriver import WebDriver
+from selenium.webdriver.support.wait import WebDriverWait
+from selenium.webdriver.support import expected_conditions as EC
+from selenium.webdriver.common.by import By
 from foxpuppet.windows import BrowserWindow
 from foxpuppet.windows.browser.panel_ui.panel_ui import PanelUI, History
 
@@ -120,7 +122,6 @@ def test_verify_links_open_in_new_window_from_history(
 ) -> None:
     """Test that links opened in new window are present in browser history."""
     panel_ui.open_new_window()
-    time.sleep(3)
     for link in links:
         selenium.get(link)
     panel_ui.open_panel_menu()
@@ -147,7 +148,6 @@ def test_clear_recent_history(
     selenium.get(url)
     panel_ui.open_history_menu()
     browser_history.clear_history()
-    time.sleep(1)
     panel_ui.open_panel_menu()
     panel_ui.open_history_menu()
     history_items = browser_history.history_items()