MAIN_VERSION can be more than 1

[psyon]

Simply setting MAIN_VERSION to 1 and the PATCH_VERSION to my version code (20140723) worked to make the app download the expansion file, but it did not work to access the file. I had to set MAIN_VERSION to the same version as PATCH_VERSION for it to work.

[moust]

According to the getExpansionAPKFileName method of com.google.android.vending.expansion.downloader.Helpers class, MAIN_VERSION should be a boolean and defined to true for main file or false for patch file.

I'm not sure of the solution because I have rarely used it, but I think you have to set MAIN_VERSION to 0.

[psyon]

https://code.google.com/p/dnd-aac/source/browse/trunk/Google+Play+Zip+Library/src/com/android/vending/expansion/zipfile/APKExpansionSupport.java?r=41

That doesn't seem to match up with their code in APKExpansionSupport.getAPKExpansionFiles which uses mainVersion directly to create the file name.

And actually, I think where you use

String fileName = Helpers.getExpansionAPKFileName(ctx, true, patchVersion);

I am not sure if that is even needed. Everything I have seen for documentation for getAssetFileDescriptor says to just pass a filename relative to the root of the zip, so just this

AssetFileDescriptor fileDescriptor = expansionFile.getAssetFileDescriptor(filename);

Maybe thing's have changed from when thish was updated from Android Market to Google Play?

[psyon]

Looking closer at Helper.getExpansionAPKFileName, it looks like you are simply supposed to pass a boolean variable to it to say whether or not you want the main file, or the patch file, but that is unrelated to MAIN_VERSION in your code.

[moust]

I never took a deeper look at this api so maybe it's not the right way to do.
For the moment I haven't the time to dig up this problem. Can you try to fix it with your suggestion and to create a pull request if you find the solution ?

[psyon]

Yes, I will try to get a pull request done soon. Also, It's probably worth including a class to extend the APEZProvider class, so that the contents of a zip file can be accessed with URLs. Using XAPReader.get() was slow for many images, but using the provider class, I was able to set images to content://com.my.app.expansion/photos/photo.jpg and have them load fine.

[psyon]

Sorry for the delay on this. I have a fork done, with all the code changes, but want to make sure it's well tested first, and I had a large project come up for work.

[adys123]

Hi psyon.
I saw that you have managed to make this plugin to work.
I want to ask you: how you managed to display the images, because I don't understand. I tried everything, but nothing works. I see in tutorial this step:

XAPKReader.get(
'image.jpg',
function (url) {
var img = new Image();
img.src = url;
document.body.appendChild(img);
},
function (error) {
console.error(error);
},
'image/jpeg'
);

Where exactly I must write this?

Thanks.

[psyon]

I used the APEZProvider class.

https://github.com/psyon/phonegap-xapkreader/blob/psyon-fixes/src/android/XAPKProvider.java

I will have a pull request soon to make sure this gets into Mousts code, but for now you can drop that file into the plugin directory. With that file in place, you would have to add this to AndroidManifest.xml

<provider android:authorities="org.apache.cordova.xapkreader.expansion" android:exported="false" android:multiprocess="true" android:name="org.apache.xapkreader.XAPKProvider">
    <meta-data android:name="mainVersion" android:value="$MAIN_VERSION" />
    <meta-data android:name="patchVersion" android:value="$PATCH_VERSION" />
</provider>

Replace the $MAIN_VERSION and $PATCH_VERSION

From there, you would be able to simply read the file like this

<img src="content://org.apache.xapkreader.expansion/image.jpg">

[adys123]

Thanks for your quick response.
Unfortunately I'm not able to make the application work.
It seems that when I write the code in AndroidManifest.xml, the application no longer works.

I have placed XAPKProvider.java in plugins folder, in org.apache.cordova.xapkreader\src\android, and even in platforms\android\src\org\apache\cordova\xapkreader. Nothing seems to work.

That is all I have done so far:
-I update the cordova to version 3.5.0
-I installed the plugin from git using this line:

cordova plugin add https://github.com/psyon/phonegap-xapkreader.git --variable MAIN_VERSION=1 --variable PATCH_VERSION=1 --variable FILE_SIZE=1095520 (with the file size that I needed).

Here I must mention that I installed the plugin from your git page and not from moust because I noticed that you have made ​​some changes.

-Then I added the necessary libraries.
-And now, I'm stuck...

Thanks for your time, psyon.

[psyon]

If you installed from my repo, then the file should have already been there, and the stuff for the manifest should have been added automatically. the code changes in my repo were done on a live app, and I copied the changes to the repo, but I have not tested it yet. Once my repo is tested, I will send a pull request to merge it into moust's

[adys123]

well.. that's interesting because I reinstalled it 2 times and everytime I have the same folder structure with the same files (XAPKAlarmReceiver, XAPKDownloaderActivity, XAPKDownloaderService, XAPKDownloaderService).
And AndroidManifest is unchanged.

[psyon]

You are probably using the master branch of my repo, and not the psyon-fixes branch. Im not even sure if you can install from my changes. Ill merge to the master branch, and you can give it a try then.

[adys123]

that explains everything.
you are right.. I used the master branch.
Then, I'll wait until you merge it.

thank you

[psyon]

It should be merged into the master branch on my repo now.

[adys123]

everything installs fine now.

But I have the same problem with AndroidManifest. Those code lines make my app to stop working before starts.

In XAPKProvider this line package org.android.cordova.xapkreader; give me an error. To get rid of it, I changed to package org.apache.cordova.xapkreader;