String argument's reset button not shown if re-input same value

[davidlatwe]

Problem

1. If the default value of the string argument is "A"
2. Type "B" and press Enter, reset button shown
3. Press reset, value fallback to default "A"
4. Type "B" again, reset button not shown

Is this an expected behavior ?

I found that it's because the self._previous attribute is holding the previous input from user, but not fallback to default when reset pressed.

qargparse.py/qargparse.py

Lines 464 to 470 in 2dcdc17

	def onEditingFinished(self):
	current = self._read()
	if current != self._previous:
	self.changed.emit()
	self._previous = current

So it's actually :

Steps	_previous
Default value of the string argument is "A"	_previous == "A"
Type "B" and press Enter, reset button shown	_previous == "B", thanks to String.onEditingFinished
Press reset, value fallback to default "A"	_previous == "B", because String.write triggered by reset did not update it
Type "B" again, reset button not shown	current == self._previous, changed signal not emit

[mottosso]

I'm actually using this right now, and have noticed issues with the reset button. Not just for String, but Enum and Integer too. I think there's an issue in logic somewhere..

With PySide2.

[mottosso]

Come to think of it, the QSpinBox issue is probably something sillier, like the default max value being 99, and it thus never reaching the default value again. :P

[mottosso]

Yes, that was it. There's a max=9999 one could pass to the add_argument or Integer arguments. In that case, my issues are probably separate from the issue you're seeing.