-
Notifications
You must be signed in to change notification settings - Fork 0
Feature#388 학교대항전 이벤트 페이지 구현 #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughAdds a new “학교대항전” event page with SSG data from a new service, multiple UI sections/components (hero, info, rank badges/cards, rank list/table, footer), Kakao Share integration via a new useScript hook and Kakao SDK typings, plus build config to support SVGR. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Next.js as Next.js (Build)
participant Service as getTopRatedSchools
participant API as Backend API
Note over Next.js: Static Generation (at build/time-based revalidate)
Next.js->>Service: getTopRatedSchools()
Service->>API: GET /applications/schools/paid-count
API-->>Service: BaseResponse<[{ schoolName, paidApplicationCount }...]>
Service-->>Next.js: data (array)
Next.js-->>User: Pre-rendered page (props: topRatedSchools)
Note over User,Next.js: Client render of Hero/Info/RankList/RankTable/Footer
sequenceDiagram
autonumber
participant User
participant Footer as FooterSection
participant Hook as useScript
participant Kakao as Kakao JS SDK
Footer->>Hook: Load kakao.min.js (async)
Hook-->>Footer: onLoad -> window.Kakao.init(KEY)
User->>Footer: Click "친구에게 공유"
alt Kakao ready
Footer->>Kakao: Share.sendCustom({ templateId: 124102 })
Kakao-->>Footer: Share dialog flow
else Kakao not ready
Footer->>User: Clipboard write of page URL + alert
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (23)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Package 변경사항
📝 추가 및 변경된 파일총 29개 파일 변경 |
📚 Storybook이 Chromatic에 배포되었습니다!
|
✅ Linked Issue
Summary by CodeRabbit
New Features
Style
Chores