Matching is broken in 1.35 for any model with a primary key

[monktastic]

In this commit, I believe

        const compositeIndex =
          current.model.uniqueIndexes.map((index) => index.name).includes(child) ||
          current.model.primaryKey?.name === child ||
          current.model.primaryKey?.fields.join('_');

should be

        const compositeIndex =
          current.model.uniqueIndexes.map((index) => index.name).includes(child) ||
          current.model.primaryKey?.name === child ||
          current.model.primaryKey?.fields.join('_') === child;

or similar. As an aside, I don't understand how the next line is supposed to work:

        if (compositeIndex) {
          return matchMultiple(item, where[child] as FindWhereArgs, current, delegates);
        }

because by pulling out child from where (which we now know is a key/index), you lose the actual key, and I think the contents won't match any of the field names. That's probably just me not understanding how this is supposed to work in general, but thought I'd point it out just in case.

@carterbush

[monktastic]

Please ignore the "aside" in my comment. I now see how matches are supposed to work with primary keys / indices:

9f7d5fc#diff-e9ec2fe800edccf98c2e124f5b5ffcbbca7859971c93e5c313ac12ca7437d220

Index:

  @@unique([userId, category], name: "blogByUserAndCategory")

Query:

        where: { blogByUserAndCategory: { userId: seededUsers[0].id, category: 'test' } },

Still, the test suite is missing a test for primary keys, which would have caught this regression.

[carterbush]

Hey @monktastic - I'm not the maintainer of this library, but if you've found a bug you should create a PR to fix it so that we the community of users can keep improving it together :)

[monktastic]

@carterbush Prisma, prismock, and the entire ecosystem (TypeScript, yarn, etc.) are completely new to me, so it was a bit of a bear to do this, but I did it. Thanks for inspiring me.

(BTW, I know you're not the maintainer, but the breaking commit was authored by you, so I figured I'd tag you.)