Skip to content

Consider Bluebird.noConflict() to restrict impact on the global JS scope #147

@semmel

Description

@semmel

Loading mr's bootstrap.js and consequently bluebird.min.js overrides the global Promise object. I would think that this is a unintended side-effect of Mr?

Yes I know that Bluebird is well-tested and compatible with the native implementations, but I this introduces a unnecessary dependency for all my code. What if a future version of Bluebird contains an error?

It seems to be easy to fix by appending .noConflict():

// file: bootstrap.js, line 181
function allModulesLoaded() {
            Promise = bootRequire("promise").noConflict();
// ..

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions