Skip to content

Fix rate limiting: extract token from header before auth middleware runs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daoistbro wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Fix rate limiting: extract token from header before auth middleware runs #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/middleware/rateLimit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,13 @@ setInterval(() => {

/**
* Get rate limit key from request
* Note: This runs BEFORE requireAuth, so we must read directly from headers
*/
function getKey(req, limitType) {
const identifier = req.token || req.ip || 'anonymous';
// Extract token directly from header since req.token isn't set yet
const auth = req.headers.authorization;
const token = auth && auth.startsWith('Bearer ') ? auth.slice(7) : null;
const identifier = token || req.ip || 'anonymous';
return `rl:${limitType}:${identifier}`;
}

Expand Down