Skip to content

script fails when offsetTop : 0 #20

@ryangall7

Description

@ryangall7

In the checkSettings() method settings[key] evaluates as false when offsetTop is 0.

the whole block of code

  for (var key in settings) {
       console.log(settings[key]);
       if (!settings[key]) {
           errors.push(settings[key]);
       }
  }

seems unnecessary since the only reason a setting would be false is on purpose since the all have defaults.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions