CASAuthentication CASUser constructor getting attributes from phpCAS

[achantrill]

I have found what appears to be a typo in the CASAuthentication code, in the constructor for the CASUser class. The following block (lines 301-306):

    foreach (self::$attributeMap as $property => $attribute) {
        if (phpCAS::hasAttribute($attribute)) {
            $method = 'set'.$property;
            $this->$method(phpCAS::getAttribute($property));
        }
    }

is checking to see if phpCAS has an attribute of $attribute, but then when it tries to retrieve the attribute, it uses getAttribute($property). It should instead look like this:

    foreach (self::$attributeMap as $property => $attribute) {
        if (phpCAS::hasAttribute($attribute)) {
            $method = 'set'.$property;
            $this->$method(phpCAS::getAttribute($attribute));
        }
    }

using the $attribute when using the phpCAS::getAttribute method. Otherwise, unless you have your properties exactly matching your attributes in your configuration file, you will get empty strings for all of your user properties.

Thanks!