From d3024208db1706cc6fa505c888157c94d5469701 Mon Sep 17 00:00:00 2001 From: meichangsu1 <1484603386@qq.com> Date: Fri, 13 Feb 2026 18:00:27 +0800 Subject: [PATCH 1/2] docs: update README and remove ulysses_size from ep_fsdp_qwen3_moe.py - Split combined "ep/sp FSDP MoE finetuning" entry in README into separate "ep FSDP MoE finetuning" and "sp FSDP finetuning" rows for clarity - Remove ulysses_size parameter from device_mesh initialization in ep_fsdp_qwen3_moe.py as it is no longer needed for the example configuration --- README.md | 3 ++- cookbook/transformers/ep_fsdp_qwen3_moe.py | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7ddd0070..6fa27ec1 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,8 @@ pip install -e . | --------------------------------- | --------------- | ------------------------------------------------- | | FSDP finetuning | transformers | [Script](cookbook/transformers/fsdp2.py) | | FSDP MoE finetuning | transformers | [Script](cookbook/transformers/fsdp2_moe.py) | -| ep/sp FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) | +| ep FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py)| +| sp FSDP finetuning | transformers | [Script](cookbook/transformers/sp_fsdp_dense.py) | | EP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) | | pp/tp/cp finetuning | megatron | [Script](cookbook/megatron/tp.py) | | pp/tp/cp MoE finetuning | megatron | [Script](cookbook/megatron/tp_moe.py) | diff --git a/cookbook/transformers/ep_fsdp_qwen3_moe.py b/cookbook/transformers/ep_fsdp_qwen3_moe.py index 6473dc63..16706eae 100644 --- a/cookbook/transformers/ep_fsdp_qwen3_moe.py +++ b/cookbook/transformers/ep_fsdp_qwen3_moe.py @@ -21,13 +21,11 @@ # 4 gpus, dp=2, ep=2 dp_size = 2 ep_size = 2 -ulysses_size = 2 device_mesh = DeviceMesh( device_type=Platform.get_platform().device_prefix(), mesh=np.arange(dp_size * ep_size).reshape(dp_size, ep_size), mesh_dim_names=('dp', 'ep'), - ulysses_size=ulysses_size, # enable sp ) twinkle.initialize( From 9d002c4ef51c71b90ccf0951f0ee3d8399f4ea4c Mon Sep 17 00:00:00 2001 From: meichangsu1 <1484603386@qq.com> Date: Fri, 13 Feb 2026 18:15:52 +0800 Subject: [PATCH 2/2] Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6fa27ec1..b615cc0b 100644 --- a/README.md +++ b/README.md @@ -69,8 +69,8 @@ pip install -e . | --------------------------------- | --------------- | ------------------------------------------------- | | FSDP finetuning | transformers | [Script](cookbook/transformers/fsdp2.py) | | FSDP MoE finetuning | transformers | [Script](cookbook/transformers/fsdp2_moe.py) | -| ep FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py)| -| sp FSDP finetuning | transformers | [Script](cookbook/transformers/sp_fsdp_dense.py) | +| ep FSDP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) | +| sp FSDP finetuning | transformers | [Script](cookbook/transformers/sp_fsdp_dense.py) | | EP MoE finetuning | transformers | [Script](cookbook/transformers/ep_fsdp_qwen3_moe.py) | | pp/tp/cp finetuning | megatron | [Script](cookbook/megatron/tp.py) | | pp/tp/cp MoE finetuning | megatron | [Script](cookbook/megatron/tp_moe.py) |