Skip to content

Commit 8c3dbc9

Browse files
authored
fix megatron multi-lora converter (#144)
1 parent 42c642b commit 8c3dbc9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/twinkle/model/megatron/megatron.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,10 @@ def _save_megatron_format(self, output_dir: str, adapter_name: str, lora_convert
11781178
cpu_state_dict = {}
11791179
for k, v in state_dict.items():
11801180
if lora_converter is not None:
1181-
k, v = lora_converter(k, v)
1181+
kv = lora_converter(k, v)
1182+
if kv is None:
1183+
continue
1184+
k, v = kv
11821185
if k is not None and v is not None:
11831186
cpu_state_dict[k] = v.cpu()
11841187

src/twinkle/model/multi_lora.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ def save_lora_converter(self, name, parameter, adapter_name):
494494
name = name.replace(f'.{_lora.adapter_name}.', '.')
495495
return name, _param
496496
else:
497-
return None, None
497+
return None
498498

499499
def set_state_dict(self, tenant_adapter_name, state_dict):
500500
_lora = self.find_lora_by_tenant(tenant_adapter_name)

0 commit comments

Comments
 (0)