From 40e51216d329acd9f1f8db82a9a2b76fe7d5cb46 Mon Sep 17 00:00:00 2001 From: 420kyle69 <66268622+420kyle69@users.noreply.github.com> Date: Wed, 20 Jul 2022 12:20:22 -0700 Subject: [PATCH 1/2] Let server decide guest user name instead of the client --- server/ServerNetworkEvents.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/server/ServerNetworkEvents.js b/server/ServerNetworkEvents.js index d3a641e1..32287188 100644 --- a/server/ServerNetworkEvents.js +++ b/server/ServerNetworkEvents.js @@ -219,19 +219,15 @@ var ServerNetworkEvents = { var player = ige.game.getPlayerByClientId(socket.id) if (player) { - player._stats.isAdBlockEnabled = data.isAdBlockEnabled; + player._stats.isAdBlockEnabled = false; } else { - if (typeof data.number != 'number') { - data.number = " lol" - } - var player = ige.game.createPlayer({ controlledBy: "human", - name: "user" + data.number, + name: "user" + (Math.floor(Math.random() * 999) + 100), coins: 0, points: 0, clientId: clientId, - isAdBlockEnabled: data.isAdBlockEnabled + isAdBlockEnabled: false }); } From 94e5e6f62001eb3d10f5f1e4b25511902a195058 Mon Sep 17 00:00:00 2001 From: 420kyle69 <66268622+420kyle69@users.noreply.github.com> Date: Wed, 20 Jul 2022 12:25:30 -0700 Subject: [PATCH 2/2] Improve lines 199-200 --- server/ServerNetworkEvents.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/ServerNetworkEvents.js b/server/ServerNetworkEvents.js index 32287188..c165be97 100644 --- a/server/ServerNetworkEvents.js +++ b/server/ServerNetworkEvents.js @@ -196,10 +196,8 @@ var ServerNetworkEvents = { purchasables: {} }; var player = ige.game.createPlayer() - for (key in userData) { - var obj = {} - obj[key] = userData[key]; - data.push(obj) + for (const key in userData) { + data.push({ [key]: userData[key] }); } player.joinGame(); player.streamUpdateData(data);