From 72514797d5b4636de6b7504dd19ab431337a9fe5 Mon Sep 17 00:00:00 2001 From: Mikael Lund Date: Wed, 23 Oct 2024 09:14:11 +0200 Subject: [PATCH 1/3] Fix code scanning alert no. 1: Potentially unsafe call to strncat Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- src/BBox/qHull/global.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BBox/qHull/global.cpp b/src/BBox/qHull/global.cpp index 7f7eead..b07d20e 100644 --- a/src/BBox/qHull/global.cpp +++ b/src/BBox/qHull/global.cpp @@ -249,7 +249,7 @@ void qh_initflags(char *command) { if (command != &qh qhull_command[0]) { *qh qhull_command = '\0'; - strncat(qh qhull_command, command, sizeof(qh qhull_command)); + strncat(qh qhull_command, command, sizeof(qh_qhull_command) - strlen(qh_qhull_command) - 1); } while (*s && !isspace(*s)) /* skip program name */ s++; From 6506dc6b0a3970cf43839fc178349c79d7049d96 Mon Sep 17 00:00:00 2001 From: Mikael Lund Date: Wed, 23 Oct 2024 09:17:12 +0200 Subject: [PATCH 2/3] Update global.cpp --- src/BBox/qHull/global.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BBox/qHull/global.cpp b/src/BBox/qHull/global.cpp index b07d20e..c26b20d 100644 --- a/src/BBox/qHull/global.cpp +++ b/src/BBox/qHull/global.cpp @@ -249,7 +249,7 @@ void qh_initflags(char *command) { if (command != &qh qhull_command[0]) { *qh qhull_command = '\0'; - strncat(qh qhull_command, command, sizeof(qh_qhull_command) - strlen(qh_qhull_command) - 1); + strncat(qh qhull_command, command, sizeof(qhull_command) - strlen(qhull_command) - 1); } while (*s && !isspace(*s)) /* skip program name */ s++; From 50536e194b4be8eb5c36522366edba0b524f2284 Mon Sep 17 00:00:00 2001 From: Mikael Lund Date: Wed, 23 Oct 2024 09:21:22 +0200 Subject: [PATCH 3/3] Update global.cpp --- src/BBox/qHull/global.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BBox/qHull/global.cpp b/src/BBox/qHull/global.cpp index c26b20d..f2e869c 100644 --- a/src/BBox/qHull/global.cpp +++ b/src/BBox/qHull/global.cpp @@ -249,7 +249,7 @@ void qh_initflags(char *command) { if (command != &qh qhull_command[0]) { *qh qhull_command = '\0'; - strncat(qh qhull_command, command, sizeof(qhull_command) - strlen(qhull_command) - 1); + strncat(qh qhull_command, command, sizeof(qh qhull_command) - strlen(qh qhull_command) - 1); } while (*s && !isspace(*s)) /* skip program name */ s++;