Skip to content

AsWorkBook taking an #seq<Item> rather than Item list #48

@patrickallensimpson

Description

@patrickallensimpson

Is there a specific reason why you opted for Item list instead of #seq<Item> as the type for the items argument? Utilizing #seq<Item> would have greatly simplified creating composable functions because it defers the computation of Item references until rendering is required.

Did you have another engineering consideration behind this decision? As far as I can see, the code works just as well when changing the argument type to items: #seq<Item>, without having to pre-allocate the entire list before rendering.

It seems like a list type would be beneficial if there were back references to access. However, in such cases, an array or ResizeArray would be the ideal choice. Currently, I don't see any such usage in the code that would imply the need for this.

So I would suggest changing the type to items:#seq which would not be a breaking change for current users since Item list is an compatible with #seq.

Thanks,
-Patrick

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions