Moving FsExcel to a gdiplus-free ClosedXML alternative

[natalie-o-perret]

With .NET 7 which is openly gonna drop System.Drawing.Common stuff for non-Windows platforms, I'm wondering if FsExcel should change the ClosedXML implementation on which it relies on to something that doesn't need System.Drawing.Common like that one?

[misterspeedy]

Hi @natalie-o-perret, sorry for the slow reply. We are well outside my area of expertise here!

It looks like the ClosedXml folks are working on the issue you linked to, so perhaps we should apply what my old boss used to call "dynamic lethargy" - i.e. wait until their work stabilizes then use that version?

[adelarsq]

@misterspeedy The lastest ClosedXml has solved this issue, but has some breaking changes aside from this

[misterspeedy]

@adelarsq Superb - thank you. I'll integrate that version and deal with any breaking changes our end. //cc @natalie-o-perret

[adelarsq]

@misterspeedy Cool! Ping me if you need help on tests. I am using ClodedXml as fallback, but would like to go back to FsExcel when possible.

[misterspeedy]

Thank you! Actually @emigajda already upgraded to the latest ClosedXml as part of their work on merged cells, released in 0.0.39. So if you did have a moment to check we are now where we hoped to be that would be wonderful - thanks!

[natalie-o-perret]

@adelarsq Superb - thank you. I'll integrate that version and deal with any breaking changes our end. //cc @natalie-o-perret

Thanks! It has been noticed ~~

I'm also curious about the perf improvement that this ClosedXML/ClosedXML#1969 will bring, and if getting rid of the gdiplus dep is gonna decrease the perf.
Perf is one of the big reasons, if not the only one I've moved to LargeXlsx but it doesn't come without hassles on some other things: salvois/LargeXlsx#17 (relates to this issue: #8)

[adelarsq]

Thank you! Actually @emigajda already upgraded to the latest ClosedXml as part of their work on merged cells, released in 0.0.39. So if you did have a moment to check we are now where we hoped to be that would be wonderful - thanks!

Cool! I just did a test here and shows a exception about missing font. Now will be necessary to inform font names?

An unhandled exception has occurred while executing the request.
System.ArgumentException: Unable to find font Calibri or fallback font Microsoft Sans Serif. Install missing fonts or specify a different fallback font through 'LoadOptions.DefaultGraphicEngine = new DefaultGraphicEngine("Fallback font name")'. Additional information is available at https://closedxml.readthedocs.io/en/latest/tips/missing-font.html page.
   at ClosedXML.Graphics.DefaultGraphicEngine.LoadFont(MetricId metricId)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at ClosedXML.Graphics.DefaultGraphicEngine.GetFont(MetricId metricId)
   at ClosedXML.Graphics.DefaultGraphicEngine.GetFont(IXLFontBase fontBase)
   at ClosedXML.Graphics.DefaultGraphicEngine.GetTextWidth(String text, IXLFontBase fontBase, Double dpiX)
   at ClosedXML.Excel.XLColumn.GetWidthInCharacters(String text, IXLFontBase font)
   at ClosedXML.Excel.XLColumn.AdjustToContents(Int32 startRow, Int32 endRow, Double minWidth, Double maxWidth)
   at ClosedXML.Excel.XLColumn.AdjustToContents(Int32 startRow, Int32 endRow)
   at ClosedXML.Excel.XLColumn.AdjustToContents(Int32 startRow)
   at ClosedXML.Excel.XLColumn.AdjustToContents()
   at ClosedXML.Excel.XLColumns.<>c.<AdjustToContents>b__13_0(XLColumn c)
   at ClosedXML.Excel.EnumerableExtensions.ForEach[T](IEnumerable`1 source, Action`1 action)
   at ClosedXML.Excel.XLColumns.AdjustToContents()
   at FsExcel.Render.AsWorkBook(FSharpList`1 items)
   at FsExcel.Render.AsFile(String path, FSharpList`1 items)
   at ...
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext)
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

[misterspeedy]

Ah, interesting! I'll see if I can find a way round that. Thank you!

…

On Mon, 27 Feb 2023 at 17:37, Adelar da Silva Queiróz < ***@***.***> wrote: Thank you! Actually @emigajda <https://github.com/emigajda> already upgraded to the latest ClosedXml as part of their work on merged cells, released in 0.0.39. So if you did have a moment to check we are now where we hoped to be that would be wonderful - thanks! Cool! I just did a test here and shows a exception about missing font. Now will be necessary to inform font names? An unhandled exception has occurred while executing the request. System.ArgumentException: Unable to find font Calibri or fallback font Microsoft Sans Serif. Install missing fonts or specify a different fallback font through 'LoadOptions.DefaultGraphicEngine = new DefaultGraphicEngine("Fallback font name")'. Additional information is available at https://closedxml.readthedocs.io/en/latest/tips/missing-font.html page. at ClosedXML.Graphics.DefaultGraphicEngine.LoadFont(MetricId metricId) at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory) at ClosedXML.Graphics.DefaultGraphicEngine.GetFont(MetricId metricId) at ClosedXML.Graphics.DefaultGraphicEngine.GetFont(IXLFontBase fontBase) at ClosedXML.Graphics.DefaultGraphicEngine.GetTextWidth(String text, IXLFontBase fontBase, Double dpiX) at ClosedXML.Excel.XLColumn.GetWidthInCharacters(String text, IXLFontBase font) at ClosedXML.Excel.XLColumn.AdjustToContents(Int32 startRow, Int32 endRow, Double minWidth, Double maxWidth) at ClosedXML.Excel.XLColumn.AdjustToContents(Int32 startRow, Int32 endRow) at ClosedXML.Excel.XLColumn.AdjustToContents(Int32 startRow) at ClosedXML.Excel.XLColumn.AdjustToContents() at ClosedXML.Excel.XLColumns.<>c.<AdjustToContents>b__13_0(XLColumn c) at ClosedXML.Excel.EnumerableExtensions.ForEach[T](IEnumerable`1 source, Action`1 action) at ClosedXML.Excel.XLColumns.AdjustToContents() at FsExcel.Render.AsWorkBook(FSharpList`1 items) at FsExcel.Render.AsFile(String path, FSharpList`1 items) at server.Planilha.gerarPlanilha(DateTime dataInicial, DateTime dataFinal, FSharpList`1 list) in /app/lib/Planilha.fs:line 125 at server.Rules.gerarPlanilha(DateTime dataInicial, DateTime dataFinal) in /app/lib/Rules.fs:line 229 at server.Handlers.RelatorioHandlers.consultar(HttpContext ctx) in /app/lib/Handlers.fs:line 47 at ***@***.***(HttpContext ctx) at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext) --- End of stack trace from previous location --- at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context) — Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGDPLWA7LW4VYGCO5KML7LWZTQ37ANCNFSM56L7VBXA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[misterspeedy]

Raised as #39

[misterspeedy]

@adelarsq what do you think of the workaround I've added in the latest comment in #41 ?