From b5d5ca0b4cc2bb74ffd1e9dd505fa92913db93fd Mon Sep 17 00:00:00 2001 From: Brandon Yang Date: Tue, 15 Apr 2025 21:59:31 -0400 Subject: [PATCH] fixing linting issues --- .github/workflows/linting.yml | 2 +- endpoints/app.py | 16 ++++++++-------- tests/handler_test.py | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 3df8e41..683db02 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -26,7 +26,7 @@ jobs: run: python -m pip install --upgrade pip pylint - name: Run Pylint - run: pylint --rcfile=tests/.pylintrc $(find tests -name "*.py") || true + run: pylint --rcfile=tests/.pylintrc $(find tests -name "*.py") diff --git a/endpoints/app.py b/endpoints/app.py index 6ee7e11..6cbe87f 100644 --- a/endpoints/app.py +++ b/endpoints/app.py @@ -23,7 +23,7 @@ def lambda_handler(event, context): Return doc: https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html """ PARAMETER_NAME = "searchTerm" - + # These headers are always included to fix the CORS Issues response = { 'headers': { @@ -37,15 +37,15 @@ def lambda_handler(event, context): response["statusCode"] = 400 response['body'] = {"error": f"Bad request: Missing query parameter '{PARAMETER_NAME}'"} return response - + if event['headers'] == None: response["statusCode"] = 400 response['body'] = {"error": "Bad request: missing header"} return response - + query_parameters = event['queryStringParameters'] header = event['headers'] - + try: session_id = header["Session-Id"] except: @@ -54,21 +54,21 @@ def lambda_handler(event, context): "searchTerm": query_parameters["searchTerm"], "pageNumber": query_parameters["pageNumber"], "refreshResults": query_parameters["refreshResults"], - "sessionID": session_id, + "sessionID": session_id, "sortParams": query_parameters["sortParams"], "filterParams": query_parameters["filterParams"] } try: response_body = search(input_json) - + except Exception as e: print(f"Exception in database query: {e}") response["statusCode"] = 500 response['body'] = {"error": "Internal Server Error"} return response - - + + response["statusCode"] = 200 response['body'] = json.dumps(response_body) diff --git a/tests/handler_test.py b/tests/handler_test.py index 8db71b0..e70aa18 100644 --- a/tests/handler_test.py +++ b/tests/handler_test.py @@ -41,10 +41,10 @@ def test_lambda_happy_path(mock_database): "matchQuality": ".2" } ]) - + event = { 'queryStringParameters': {'name': 'default'} } context = {} - + response = lambda_handler(event, context) validate_200_response(response)