-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Description
Currently, the https://github.com/minkphp/webdriver-classic-driver/blob/main/tests/bootstrap.php file automatically starts/stops the web server with test fixtures used during testing. This is an innovative approach compared to how other drivers would do this.
If we go away from the current approach (start web server inside a test suite), then all that stuff needs to be moved into the GitHub Actions workflow (as in other drivers).
Possible downsides to the current approach (I'm not saying it's a wrong approach in general):
- Project contributors might already have a Web Server running locally and this project cloned in its DocumentRoot. In that scenario, they don't need another Web Server to be started and only need to map paths in the
phpunit.xml. - The 8002 port might be already occupied on the contributor's machine, which would result in the inability to run tests.
- The Symfony's Process component is being used, but it's not explicitly listed as a dev dependency in the composer and that means, that it's not guaranteed to be present as a dependency.
Metadata
Metadata
Assignees
Labels
No labels