end passing through with no delay

[mark-hahn]

If there is no data, then BufferedStream is passing the end event through immediately, before any end event has been registered to listen for it. The defeats the purpose of holding off the stream until after an async call. It should hold off even an empty stream.

            req.pipe (req.body = new BufferedStream 1e6)

        ... snipped an async call ...

            proxyReq = http.request options, (resProx) ->
                res.writeHeader resProx.statusCode, resProx.headers
                resProx.pipe res

            req.body.pipe proxyReq

I'll write my own version again until this is resolved. I get the feeling I am the only one using this.

[mark-hahn]

I've got a patch that works, although I'd still like to see it fixed so the code I showed before worked.

In main.js ...

BufferedStream.prototype.end = function () {
  this.closed = true;
  this.emit('end');
}

... then in my code ...

        if req.body.closed then proxyReq.end()
        else req.body.pipe proxyReq
        return

[mark-hahn]

I have a better fix that works the way I originally wanted it to. Add this line to the end of BufferedStream.prototype.end

  this.endRecvd = true;

and add this line to the end of BufferedStream.prototype.pipe

  if(this.endRecvd) dest.end();

P.S. I apologize if I seemed rude earlier. I was tired.

[dominictarr]

I'm also using this, and just encountered this problem too.

when pipe is called, the BufferedStream should emit 'data' rather than calling dest. write in case more than one stream is piped to it.

[dominictarr]

also, I love/hate to toot my own horn, but I have another implementation of this idea over here https://github.com/dominictarr/event-stream/blob/master/index.js#L350

[mikeal]

someone should send me a pull request :)