Determine the fate of the proof key tests

[tylerbutler]

The proof key tests can’t work as-is because there’s no signing key. We can disable the tests, but I think a better fix would be to provide a dummy WOPI discovery XML file in this repo and expose a key there. It could be a fixed key since it’s only used for testing.

[raffis]

Should be disabled for now, it is irritating that those tests fail even if implemented correctly.

[thomaslevesque]

a better fix would be to provide a dummy WOPI discovery XML file in this repo and expose a key there. It could be a fixed key since it’s only used for testing.

👍

That's what I did in my working copy to be able to pass those tests. Most of the necessary code is already there, it just needs a key.

[thomaslevesque]

I'd like to emphasize how important it is to be able to run these tests locally. We can't use the test WOPI environment to debug on the local machine, so being able to use wopi-validator-core is extremely helpful. There's very little work needed to make the proof key tests work; I can send a PR if you like.

[tylerbutler]

PRs are welcome.

[thomaslevesque]

@tylerbutler did you see my PR (#86)? I didn't receive any feedback

[sergiypopovych7576]

@thomaslevesque @tylerbutler
Hi guys, is there any progress on this? I see we have a PR, but it was not reviewed

Also, maybe we can have a small update in Readme to describe how to run proof key tests?

[mikeebowen]

@tylerbutler @thomaslevesque , there hasn't been an update on this in quite a while. Are there plans to merge this? Working tests for the proof keys would be very helpful. Thanks!