Skip to content
This repository was archived by the owner on Jun 11, 2020. It is now read-only.
This repository was archived by the owner on Jun 11, 2020. It is now read-only.

URL in README of typing packages #465

@FranklinYu

Description

@FranklinYu

For example, @types/lodash says

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped.git/tree/master/types/lodash

Note the .git extension. That URL is a 404. Correct URL is https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash. The line is generated in

https://github.com/Microsoft/types-publisher/blob/e40d8bcd9fa7eaf330b195f7a22110a6f1c0d454/src/lib/package-generator.ts#L163

So typing.sourceRepoURL seems to have the .git extension, while it shouldn't be. The typing information tracks to PackageBase.sourceRepoURL, which is assigned in

https://github.com/Microsoft/types-publisher/blob/e40d8bcd9fa7eaf330b195f7a22110a6f1c0d454/src/lib/packages.ts#L182-L186

But BaseRaw.sourceRepoURL says that .git extension should not be there in the first place:

https://github.com/Microsoft/types-publisher/blob/e40d8bcd9fa7eaf330b195f7a22110a6f1c0d454/src/lib/packages.ts#L165-L166

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions