-
Notifications
You must be signed in to change notification settings - Fork 188
Open
Labels
acceptedWe are working on this and hope to release it into the productWe are working on this and hope to release it into the product
Description
The code in FileHasher.HashAlgorithmNames seems to be incorrect when aggregating. The current code mimics that we do when validating, which uses IConfiguration.HashAlgorithm.Value. That's great when validating incoming SBOMs, but is likely incorrect when we're generating the aggregated SBOM.
My suggestion would be to add a new property to IConfiguration to indicate not just the action mode, but also the action phase. The action mode would be constant throughout the process, but the action phase would change as aggregation moves from validating to generating. The code that currently switches on the action mode would then be updated to switch on the action phase where appropriate.
Metadata
Metadata
Assignees
Labels
acceptedWe are working on this and hope to release it into the productWe are working on this and hope to release it into the product