Skip to content

[inetstack] Not all packets from push batch are being added to unsent queue #1625

@iyzhang

Description

@iyzhang

Description

If the send window closes during a batch send, we stop adding packets to the unsent queue. Since we are still incrementing the unsent sequence number, those packets are effectively lost.

How to Reproduce

Steps to reproduce the behavior:

  1. Send enough packets in a batch to fill the send window
  2. After receiving some acks, we should send all of the unsent packets.
  3. Instead we send one packet and drop the others.

Expected Behavior

We should buffer unsent packets until the send window opens and then reliably send all of the unsent packets.

Metadata

Metadata

Assignees

Labels

bugSomething Isn't Working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions