From 62cdbe64b38580a8a3f39f6b720fbe1971d694c5 Mon Sep 17 00:00:00 2001 From: Ron Koppelaar Date: Thu, 17 Aug 2023 17:28:43 +0200 Subject: [PATCH 1/2] Fix #130 - Remove try function because LockTable might not work in near future in Online --- businessCentral/src/ADLSECommunication.Codeunit.al | 8 +------- businessCentral/src/ADLSEExecute.Codeunit.al | 5 +---- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/businessCentral/src/ADLSECommunication.Codeunit.al b/businessCentral/src/ADLSECommunication.Codeunit.al index b0e4365..2f86280 100644 --- a/businessCentral/src/ADLSECommunication.Codeunit.al +++ b/businessCentral/src/ADLSECommunication.Codeunit.al @@ -250,13 +250,7 @@ codeunit 82562 "ADLSE Communication" end; end; - [TryFunction] - procedure TryUpdateCdmJsons(EntityJsonNeedsUpdate: Boolean; ManifestJsonsNeedsUpdate: Boolean) - begin - UpdateCdmJsons(EntityJsonNeedsUpdate, ManifestJsonsNeedsUpdate); - end; - - local procedure UpdateCdmJsons(EntityJsonNeedsUpdate: Boolean; ManifestJsonsNeedsUpdate: Boolean) + procedure UpdateCdmJsons(EntityJsonNeedsUpdate: Boolean; ManifestJsonsNeedsUpdate: Boolean) var ADLSESetup: Record "ADLSE Setup"; ADLSEGen2Util: Codeunit "ADLSE Gen 2 Util"; diff --git a/businessCentral/src/ADLSEExecute.Codeunit.al b/businessCentral/src/ADLSEExecute.Codeunit.al index c824d33..7d5512a 100644 --- a/businessCentral/src/ADLSEExecute.Codeunit.al +++ b/businessCentral/src/ADLSEExecute.Codeunit.al @@ -87,10 +87,7 @@ codeunit 82561 "ADLSE Execute" end; // update Jsons - if not ADLSECommunication.TryUpdateCdmJsons(EntityJsonNeedsUpdate, ManifestJsonsNeedsUpdate) then begin - SetStateFinished(Rec, TableCaption); - exit; - end; + ADLSECommunication.UpdateCdmJsons(EntityJsonNeedsUpdate, ManifestJsonsNeedsUpdate); if EmitTelemetry then ADLSEExecution.Log('ADLSE-007', 'Jsons have been updated', Verbosity::Normal, CustomDimensions); From c4bb4f868d9187a0a55da5bd4b7514f115c160ee Mon Sep 17 00:00:00 2001 From: Ron Koppelaar Date: Thu, 17 Aug 2023 17:33:58 +0200 Subject: [PATCH 2/2] Increase app version --- businessCentral/app.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/businessCentral/app.json b/businessCentral/app.json index 41bc9a9..64b4a1f 100644 --- a/businessCentral/app.json +++ b/businessCentral/app.json @@ -4,7 +4,7 @@ "publisher": "The bc2adls team, Microsoft Denmark", "brief": "Sync data from Business Central to the Azure storage", "description": "Exports data in chosen tables to the Azure Data Lake and keeps it in sync by incremental updates. Before you use this tool, please read the SUPPORT.md file at https://github.com/microsoft/bc2adls.", - "version": "1.3.15.0", + "version": "1.3.16.0", "privacyStatement": "https://go.microsoft.com/fwlink/?LinkId=724009", "EULA": "https://go.microsoft.com/fwlink/?linkid=2009120", "help": "https://go.microsoft.com/fwlink/?LinkId=724011",