From d3798ba2de4358b0fc7f9dfba662c781bb470022 Mon Sep 17 00:00:00 2001 From: alexbarthnet <81780226+alexbarthnet@users.noreply.github.com> Date: Thu, 10 Mar 2022 11:50:38 -0600 Subject: [PATCH] Updated driver version check The existing driver version check will fail when a driver has version "1.10.#.#" and the required minimum version is "1.9.#.#" as is the case with the current Intel E810 drivers. Casting the current and minimum driver strings to [System.Version] objects fixed the issue in my testing. --- Tests/unit/modal.unit.tests.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tests/unit/modal.unit.tests.ps1 b/Tests/unit/modal.unit.tests.ps1 index 0f35e71..07f1332 100644 --- a/Tests/unit/modal.unit.tests.ps1 +++ b/Tests/unit/modal.unit.tests.ps1 @@ -69,7 +69,7 @@ Describe "[Modal Unit]" -Tag Modal { ### Verify interface is using at least the recommended driver version It "[SUT: $nodeName]-[RDMAEnabledAdapter: $($thisRDMAEnabledAdapter.Name)]-[Noun: NetAdapter] Driver must use the recommended version ($($thisDriver.MinimumDriverVersion) or later" { - ($actNetAdapterState.NetAdapter | Where-Object Name -eq $thisRDMAEnabledAdapter.Name).DriverVersionString -ge $thisDriver.MinimumDriverVersion | Should be $true + ([System.Version]($actNetAdapterState.NetAdapter | Where-Object Name -eq $thisRDMAEnabledAdapter.Name).DriverVersionString) -ge [System.Version]($thisDriver.MinimumDriverVersion) | Should be $true } } } @@ -135,7 +135,7 @@ Describe "[Modal Unit]" -Tag Modal { ### Verify interface is using at least the recommended driver version It "[SUT: $nodeName]-[VMSwitch: $($thisCfgVMSwitch.Name)]-[RDMAEnabledAdapter: $($thisRDMAEnabledAdapter.Name)]-[Noun: NetAdapter] Driver must use the recommended version ($($thisDriver.MinimumDriverVersion)) or later" { - ($actNetAdapterState.NetAdapter | Where-Object Name -eq $thisRDMAEnabledAdapter.Name).DriverVersionString -ge $thisDriver.MinimumDriverVersion | Should be $true + ([System.Version]($actNetAdapterState.NetAdapter | Where-Object Name -eq $thisRDMAEnabledAdapter.Name).DriverVersionString) -ge [System.Version]($thisDriver.MinimumDriverVersion) | Should be $true } } }