From 64d82bd93d4388e09829454873cfd472d8f9d797 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Tue, 16 Sep 2025 12:55:30 +0200 Subject: [PATCH] ci: fix skipping logic In https://github.com/microsoft/VFSForGit/pull/1866 I introduced logic to skip builds and tests when a previous workflow run already succeeded for the same commit. However, the original revision of that Pull Request tried something _even more_ elaborate, and when I dropped that elaborate logic (because it is a bit fragile), I made a mistake in the replacement logic. The `run.status` can never be `success`, it can be `completed` and _`run.conclusion`_ can be `success`. So let's test for that instead ;-) Signed-off-by: Johannes Schindelin --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 74c6f8e47..dbcea1640 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -93,7 +93,7 @@ jobs: } } - if (run.status === 'success') return run.html_url + if (run.status === 'completed' && run.conclusion === 'success') return run.html_url } return '' } catch (e) {