From 2599b35f571dc0ea48966680046002f3eb0cf0e9 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Wed, 4 Feb 2026 14:39:20 -0800 Subject: [PATCH 1/2] Disable macOS in PR CI --- .github/workflows/ci.yml | 52 +++++++++++++++------------------------- 1 file changed, 19 insertions(+), 33 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e44deafac72c4..4e6d3f4ae4f7e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,12 +29,11 @@ jobs: fail-fast: ${{ github.event_name == 'merge_group' }} matrix: config: - # Main builds + # PRs only check the newest and oldest Node versions. + # macOS is never checked in PR, as that resource is limited. - os: ubuntu-latest node-version: '24' bundle: true - - # Other builds (skipped in merge queues) - os: windows-latest node-version: '24' bundle: true @@ -42,58 +41,48 @@ jobs: - os: macos-latest node-version: '24' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} + - os: ubuntu-latest node-version: '22' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} - os: windows-latest node-version: '22' bundle: true - skip: ${{ github.event_name == 'merge_group' }} - # Skip macOS for this version; resources are limited. - # - os: macos-latest - # node-version: '22' - # bundle: true - # skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} + - os: ubuntu-latest node-version: '20' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} - os: windows-latest node-version: '20' bundle: true - skip: ${{ github.event_name == 'merge_group' }} - # Skip macOS for this version; resources are limited. - # - os: macos-latest - # node-version: '20' - # bundle: true - # skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} + - os: ubuntu-latest node-version: '18' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} - os: windows-latest node-version: '18' bundle: true - skip: ${{ github.event_name == 'merge_group' }} - # Skip macOS for this version; resources are limited. - # - os: macos-latest - # node-version: '18' - # bundle: true - # skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} + - os: ubuntu-latest node-version: '16' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} - os: windows-latest node-version: '16' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} - os: macos-latest node-version: '16' bundle: true - skip: ${{ github.event_name == 'merge_group' }} + skip: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} + - os: ubuntu-latest node-version: '14' bundle: true @@ -102,12 +91,9 @@ jobs: node-version: '14' bundle: true skip: ${{ github.event_name == 'merge_group' }} - # No Node 14 on ARM macOS - # - os: macos-latest - # node-version: '14' - # bundle: true - # skip: ${{ github.event_name == 'merge_group' }} + # Node 14 does not support macOS ARM. + # --no-bundle build - os: ubuntu-latest node-version: 'lts/*' bundle: false From 360fd89f5d97ebfd87222ecd55b095626da97014 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Wed, 4 Feb 2026 14:40:51 -0800 Subject: [PATCH 2/2] Comment --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4e6d3f4ae4f7e..33061d075fb31 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,7 +30,7 @@ jobs: matrix: config: # PRs only check the newest and oldest Node versions. - # macOS is never checked in PR, as that resource is limited. + # macOS only ever checks the neest and oldest Node versions, but never in PR runs. - os: ubuntu-latest node-version: '24' bundle: true