Skip to content

Expose time provider for TimeWindowFilter #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhiyuanliang-ms merged 1 commit into from
Oct 22, 2025
Merged

Expose time provider for TimeWindowFilter #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.FeatureManagement/FeatureFilters/TimeWindowFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public TimeWindowFilter(ILoggerFactory loggerFactory = null)
public IMemoryCache Cache { get; set; }

/// <summary>
/// This property allows the time window filter in our test suite to use simulated time.
/// This property allows the time window filter to use custom <see cref="TimeProvider"/>.
/// </summary>
internal TimeProvider SystemClock { get; set; }
public TimeProvider SystemClock { get; set; }

/// <summary>
/// Binds configuration representing filter parameters to <see cref="TimeWindowFilterSettings"/>.
Expand Down
3 changes: 2 additions & 1 deletion src/Microsoft.FeatureManagement/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ private static IFeatureManagementBuilder GetFeatureManagementBuilder(IServiceCol
builder.AddFeatureFilter<TimeWindowFilter>(sp =>
new TimeWindowFilter()
{
Cache = sp.GetRequiredService<IMemoryCache>()
Cache = sp.GetRequiredService<IMemoryCache>(),
SystemClock = sp.GetService<TimeProvider>() ?? TimeProvider.System,
});

builder.AddFeatureFilter<ContextualTargetingFilter>();
Expand Down